Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle custom importer #221

Open
stefanocudini opened this issue Oct 12, 2020 · 0 comments
Open

handle custom importer #221

stefanocudini opened this issue Oct 12, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@stefanocudini
Copy link

stefanocudini commented Oct 12, 2020

hi,

for my case study I was need to write a custom importer for specific opendata of my region: Trentino Alto Adige in Italy.
handle in the docker compose here:
https://github.com/DigitalCommonsLab/docker-pelias-geocoder/blob/master/projects/italy-trentino/docker-compose.yml#L130
this importer is published here:
https://github.com/DigitalCommonsLab/pelias-importer-trentino-opendata

I'm created this simple project based on Portland metro:
https://github.com/DigitalCommonsLab/docker-pelias-geocoder/tree/master/projects/italy-trentino
and unfortunately to use this I had to make a change to the base scripts about download,prepare phases here:
https://github.com/DigitalCommonsLab/docker-pelias-geocoder/blob/master/cmd/download.sh#L12

now I wanted to send you a PR to share the work done in italy-trentino.
But I realize that the changes inside the /cmd directory to the base scripts are not compatible with this project

I wanted to ask you if you have foreseen a way to integrate custom importers like my case.
I think for example to transform the script /cmd/download.sh into a directory /cmd/download.d/*.sh directory and run the scripts for all importers(*nix style)

or refact the filesystem of this project differently to be extensible

@stefanocudini stefanocudini added the enhancement New feature or request label Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant