New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Different errors returned when cache is enabled/disabled #452
Comments
I'm relying on the quite expressive However, this issue prevents me from doing that for more complicated grammars:
|
Another grammar for which the error applies:
Input:
With results cache disabled, the above produces this error:
With results cache enabled, the error changes to:
The cache disabled error is correct, as |
Failing test cases added with #555 |
The reason for this issue seems to be:
In a local prototype based on I could attempt a fix for |
Can you show me your local prototype based on |
You can have a look at a fix here. |
It does not work properly yet for nested silenced elements: Grammar:
Input:
Expected Message:
Actual Message:
Cf. failing test case. |
@nikku This should be resolved now (thanks to you 🙇 ), with all 3 of the test cases passing (including the 3rd one for nested silenced elements). The fix is present in the latest |
Thanks. |
I've tested your changes today. From what I see f5b323b#diff-cd2c6b13fdcedf68a390c8bb6ea65cafR148 introduces a breaking change, as it effectively removes the |
😨 oops, that was a stupid mistake. Gonna fix that soon, thanks for the heads up |
Tried to create a test case but failed 😢. I see that line having an impact on one of my more complicated grammars though. |
Restored the guard in d06a5b5 and pushed the changes to |
@nikku Is it fixed, or are you still having this problem? Just want to know whether I should reopen this issue. |
It's fixed. |
@nikku - It's not fixed. Nothing was released. |
I've stopped hoping for pegjs and looked elsewhere a long time ago for exactly this reason. No release = no one can actually use it. Pegjs has been historically bad with releases. |
I am hoping to change the peg release cycle by:
If something like that happened, under any set of hands, and then releases actually started, would you give it another chance? |
Wish you the best of luck to accomplish that. |
thanks 😁 We'll see. |
Grammar:
Input:
With results cache disabled, the above produces this error:
With results cache enabled, the error changes to:
The errors should be the same in both cases.
Original report
The text was updated successfully, but these errors were encountered: