Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation is unclear about Phantom, Page objects and their difference from "native" PhantomJS phantom and page objects #57

Open
n1313 opened this issue Mar 29, 2017 · 0 comments

Comments

@n1313
Copy link

n1313 commented Mar 29, 2017

The phantom.run("h1"... code example in README.js uses phantom.run and phantom.addCookie methods. First one is a custom phridge method, second is a native PhantomJS method, so these two phantom objects must be different. Since both objects are unfortunately named the same, it It is not immediately obvious that they are, in fact, very different, and when does the switch from one to another occur, so it is relatively easy to call phantom.openPage inside phantom.run callback and wonder why it doesn't work.

The README notes that "phantom-object provided by phridge is completely different to the phantom-object inside PhantomJS", but it is unclear how to tell these two objects apart in the API reference. Which phantom is returned by phridge.spawn()? Which page is returned by phantom.createPage()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant