Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support slimerjs? #46

Open
laggingreflex opened this issue Jan 31, 2016 · 6 comments
Open

support slimerjs? #46

laggingreflex opened this issue Jan 31, 2016 · 6 comments

Comments

@laggingreflex
Copy link
Contributor

I tried using this with slimerjs (replacing the phantomjs module and supplying .path to slimerjs) and it worked, which isn't surprizing as slimer aims to have almost identical API as phantom, and many other phantom bridges support it as well.

thoughts?

@jhnns
Copy link
Member

jhnns commented Jan 31, 2016

That's interesting. We could provide an option to specify the path. This would allow the developer to pass in the exact version of phantomjs or slimerjs – on their own risk of course 😉

However, should phantomjs still be a dependency of phridge then?

@moshewe
Copy link

moshewe commented Feb 24, 2016

I think so, as Phantom is still the default headless browser...

@jhnns
Copy link
Member

jhnns commented Feb 25, 2016

Yep, sounds reasonable.

@mynoheart
Copy link

module child_process not exist in slimerjs, you comment this line in lib/phantom/start.js ?

@laggingreflex
Copy link
Contributor Author

@mynoheart Hmm, I don't remember commenting that line, no

@mynoheart
Copy link

Please, write how you replace phantom to slimer more detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants