New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strange frontend time (Turbolinks?) #33

Open

whytrall opened this issue Mar 2, 2018 · 0 comments · May be fixed by #35

whytrall commented Mar 2, 2018

When a page is loaded using Cmd+R, everything works just fine.

But if I navigate to a different page, the timer goes crazy:

This started after I added Turbolinks, which may be the problem.

glaszig added a commit to glaszig/peek-performance_bar that referenced this issue


          fix ajax timing calculation

4c70115

ajax timings are derived from `event.timeStamp` values. latest browser improvements in anti-fingerprinting measures made APIs return timestamps with reduced time precision. calculating timings with those values with `new Date().getTime()` will blow up because it returns a different precision value. the solution is to use `performance.now()` in place of `Date()`

https://developer.mozilla.org/en-US/docs/Web/API/Event/timeStamp
https://developer.mozilla.org/en-US/docs/Web/API/DOMHighResTimeStamp
https://developer.mozilla.org/en-US/docs/Web/API/Performance/now

should resolve peek#33
should resolve peek#25

glaszig linked a pull request

that will close this issue

fix ajax timing calculation #35

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment