Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID3v2 frame size is extracted incorrectly #18

Open
mipper opened this issue Oct 11, 2021 · 0 comments · May be fixed by #19
Open

ID3v2 frame size is extracted incorrectly #18

mipper opened this issue Oct 11, 2021 · 0 comments · May be fixed by #19

Comments

@mipper
Copy link

mipper commented Oct 11, 2021

ID3v2.4 Frame sizes are calculated incorrectly. Currently these sizes are calculated as a plain 32-bit integer rather than as a 32-bit sync-safe integer. This means that the size of any frame larger than 0x7f is being returned incorrectly. In addition, once you hit a frame that's > 0x7f, processing of frames will exit so no further frames will be processed. A good example of this is the MCDI tag that is often big enough to trigger this issue.

@mipper mipper linked a pull request Oct 11, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant