Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imputers #13

Open
tresink opened this issue Dec 4, 2019 · 2 comments
Open

Imputers #13

tresink opened this issue Dec 4, 2019 · 2 comments

Comments

@tresink
Copy link

tresink commented Dec 4, 2019

Hi,

First of all, congrats on a nice package! I read the medium article and immediately tried it.

One thing I am wondering is, is there a way to use imputers from sklearn with pdpipe? Or could you give an example on how to use any class with the fit, transform and fit_transform method with pdpipe?

Kind regards,

Tim

@shaypal5
Copy link
Collaborator

shaypal5 commented Jan 4, 2020

Hey @tresink ,

Thank you for your kind words. :)

Yes, it should be fairly easy to write a small generic adapter around sklearn imputers. Basically the only thing missing is casting the data structure from a numpy array back to a dataframe.

I think one could even write a generic wrapper doing this to np.ndarray-to-np.ndarray sklearn transformer.

I'll try to get to it soon, but if you want to take a jab at this, take a look at the documentation section that talks about creating additional stages:
https://pdpipe.github.io/pdpipe/doc/pdpipe/#creating-additional-stages

Especially at the part about ad-hoc pipeline stages...

Cheers,
Shay

@shaypal5
Copy link
Collaborator

shaypal5 commented Feb 4, 2022

@carbonleakage

This is also a great first issue.

It can also lead to writing, as a second stage, a generic column-based stage wrapper for any matrix-to-matrix sklearn transformer. What do you say? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants