Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download progress was not shown with large package installation #2878

Open
1 task done
ewfian opened this issue May 12, 2024 · 1 comment
Open
1 task done

Download progress was not shown with large package installation #2878

ewfian opened this issue May 12, 2024 · 1 comment
Labels
🐛 bug Something isn't working 🤔 not enough info Requires more information to clarify the issue

Comments

@ewfian
Copy link

ewfian commented May 12, 2024

  • I have searched the issue tracker and believe that this is not a duplicate.

Make sure you run commands with -v flag before pasting the output.

Steps to reproduce

Thank you for creating this great project, I love pdm but it always bothers me when I install packages,

I noticed that this PR added a download progress. When installing some small packages, I did observe that the progress was working, but when installing a large package, the progress is not displayed during the download, and 100% is displayed at the moment the download is completed.

image
image

dependencies = [
    "spacy>=3.7.4",
    "ja_core_news_lg @ https://github.com/explosion/spacy-models/releases/download/ja_core_news_lg-3.7.0/ja_core_news_lg-3.7.0-py3-none-any.whl",
    "fugashi[unidic-lite]>=1.3.2",
    "sentence-transformers>=2.7.0",
    "torch>=2.3.0",
]
[[tool.pdm.source]]
url = "https://download.pytorch.org/whl/cu118"
verify_ssl = true
name = "torch"
include_packages = ["torch"]

Actual behavior

The progress is not displayed during the download, and 100% is displayed at the moment the download is completed.

Expected behavior

Progress is displayed correctly during the download process

Environment Information

# Paste the output of `pdm info && pdm info --env` below:
PDM version:
  2.15.1    
Python Interpreter:
  C:\Users\ewfian\***\.venv\Scripts\python.exe (3.12)
Project Root:
  C:/Users/ewfian/***
Local Packages:
{
  "implementation_name": "cpython",
  "implementation_version": "3.12.3",
  "os_name": "nt",
  "platform_machine": "AMD64",
  "platform_release": "10",
  "platform_system": "Windows",
  "platform_version": "10.0.19045",
  "python_full_version": "3.12.3",
  "platform_python_implementation": "CPython",
  "python_version": "3.12",
  "sys_platform": "win32"
}

Poetry can accurately report the download progress. I really hope that pdm can also improve this.

@ewfian ewfian added the 🐛 bug Something isn't working label May 12, 2024
@frostming
Copy link
Collaborator

I can't observe this (on mac m1)
image

@frostming frostming added the 🤔 not enough info Requires more information to clarify the issue label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🤔 not enough info Requires more information to clarify the issue
Projects
None yet
Development

No branches or pull requests

2 participants