Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider building wheel from sdist to ensure a proper sdist is created. #2843

Open
BurningLutz opened this issue Apr 22, 2024 · 0 comments
Open
Labels
⭐ enhancement Improvements for existing features

Comments

@BurningLutz
Copy link

Is your feature/enhancement proposal related to a problem? Please describe.

I have some Cython codes (.pyx files) in my project, and I use setuptools backend (the only backend supports building C extensions AFAIK) to compile them.

For source installation, those .pyx files should be included in sdist, but setuptools doesn't include them by default.

The problem is, currently pdm build will always succeed to build the sdist and the wheel even if those .pyx files are not included in the sdist, and the created sdist cannot be installed due to the lack of .pyx files.

Describe the solution you'd like

I suggest we first build the sdist, and then build the wheel from that sdist. This is the same approach as build.

@BurningLutz BurningLutz added the ⭐ enhancement Improvements for existing features label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭐ enhancement Improvements for existing features
Projects
None yet
Development

No branches or pull requests

1 participant