Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install an build a project from github #2763

Closed
ioangatop opened this issue Apr 2, 2024 · 3 comments
Closed

Install an build a project from github #2763

ioangatop opened this issue Apr 2, 2024 · 3 comments
Labels
⭐ enhancement Improvements for existing features

Comments

@ioangatop
Copy link

ioangatop commented Apr 2, 2024

Hi! I would like to install a library from Github, but as it has some C++ dependencies, I would like to build it - basically it includes ext_modules

For that, I would have to pass an env variable MMCV_WITH_OPS=1. Specifically, with pip I'm doing the following:

pip install torch==2.1.0
MMCV_WITH_OPS=1 pip install git+https://github.com/open-mmlab/mmcv

How can I do this with pdm? The command MMCV_WITH_OPS=1 pdm add git+https://github.com/open-mmlab/mmcv does not seem to work - it installs the wheel but does not seem to build it

Thank you

@ioangatop ioangatop added the ⭐ enhancement Improvements for existing features label Apr 2, 2024
@ioangatop
Copy link
Author

ioangatop commented Apr 2, 2024

It is worth to note that I tried to add in pyproject the following:

[[tool.pdm.source]]
type = "find_links"
url = "https://download.openmmlab.com/mmcv/dist/cpu/torch2.1/index.html"
name = "mmcv"

and i have the following logs: Terminal.log

👉 this is the one from pip: Terminal.log

which seems to build smthing... but does it use the setup.py of mmcv?

however the following command does not work:

pdm run python -c "import mmcv; from mmcv.ops import get_compiler_version"

@frostming
Copy link
Collaborator

frostming commented Apr 3, 2024

it installs the wheel but does not seem to build it

I don't have much time to investigate but there is no wheel for a git dependency and the log clearly shows it was building the package.

@ioangatop
Copy link
Author

@frostming yes indeed, I'm also not sure what is going on... probably in the near future try to investigate more and keep you posted

@frostming frostming closed this as not planned Won't fix, can't repro, duplicate, stale May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭐ enhancement Improvements for existing features
Projects
None yet
Development

No branches or pull requests

2 participants