We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expected Behaviour See #468. The pace feature should be based on the actual end slide, and not on the last slide of the PDF.
Actual Behaviour The pace feature seems to be based on the last slide of the PDF, i.e. I can get an orange indicator on the last slide.
Steps to reproduce
Notes https://github.com/pdfpc/pdfpc/blob/14344bc203cfff71a1b72deb161e003c9b480bb2/src/classes/presentation_controller.vala#L382C69-L382C82
I think that the fix in 052403d is actually wrong, it should have been metadata.get_end_user_slide() + 1.
metadata.get_end_user_slide() + 1
pdfpc version: 4.6.0 Used Distribution (GTK version, Vala version): Fedora Display Server (X11/Wayland): X11 HiDPI Setting (yes/no): unknown
The text was updated successfully, but these errors were encountered:
It seems like the actual issue might be that the fix from 052403d has been accidentally reverted in f88e1c70, which was merged into master (#634)
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
Expected Behaviour
See #468. The pace feature should be based on the actual end slide, and not on the last slide of the PDF.
Actual Behaviour
The pace feature seems to be based on the last slide of the PDF, i.e. I can get an orange indicator on the last slide.
Steps to reproduce
Notes
https://github.com/pdfpc/pdfpc/blob/14344bc203cfff71a1b72deb161e003c9b480bb2/src/classes/presentation_controller.vala#L382C69-L382C82
I think that the fix in 052403d is actually wrong, it should have been
metadata.get_end_user_slide() + 1
.pdfpc version: 4.6.0
Used Distribution (GTK version, Vala version): Fedora
Display Server (X11/Wayland): X11
HiDPI Setting (yes/no): unknown
The text was updated successfully, but these errors were encountered: