Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated code contains both tabs and spaces #87

Open
vde-developer opened this issue Jul 18, 2022 · 2 comments
Open

Generated code contains both tabs and spaces #87

vde-developer opened this issue Jul 18, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@vde-developer
Copy link

When using craftsman, generated classes contain a mix of tabs and spaces. Yes i know it doesn't matter functionally, and i don't have an opinion on tabs or spaces, just the mix of both can cause empty diffs in some diff software.

image

Craftsman version:
0.15.0

@vde-developer vde-developer added the bug Something isn't working label Jul 18, 2022
@pdevito3 pdevito3 added enhancement New feature or request and removed bug Something isn't working labels Jul 18, 2022
@pdevito3
Copy link
Owner

Yeah there should be consistency here. Not sure when I'll get to this, but noted and I'll try to get to this.

If you want to submit a PR to fix them or at least some of the higher traffic classes, I'll accept it.

In the meantime, I'd recommend a dotnet format to fix them after a scaffold and before a commit.

@vde-developer
Copy link
Author

Thanks about the dotnet format tip!

I've checked the behavior of generating classes with Craftsman after replacing all tabs with 4 spaces, and it seems to work as for me... But i honestly haven't had enough experience using it to know if I'm missing anything.

If anyone with more experience with Craftsman want to look I've created a pull request.
#88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants