Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log flood #272

Open
abique opened this issue Mar 16, 2024 · 3 comments · May be fixed by #283
Open

Log flood #272

abique opened this issue Mar 16, 2024 · 3 comments · May be fixed by #283

Comments

@abique
Copy link
Contributor

abique commented Mar 16, 2024

Hi,
When turning on info, I get a huge amount of logs from symphonia:

[2024-03-16T11:04:01Z INFO  symphonia_core::probe] found the format marker [66, 4c, 61, 43] @ 0+2 bytes.
@pdeljanov
Copy link
Owner

You're probably probing many files at a time?

This will be quieter in version 0.6 (dev-0.6 branch), but I think the best practice here is for app developers to set a log filter when initializing your logger.

@abique
Copy link
Contributor Author

abique commented Mar 22, 2024

Yes about a thousand files in a go.
That's why this single line of log turn into flood :-)

@abique
Copy link
Contributor Author

abique commented Mar 22, 2024

I think the best practice here is for app developers to set a log filter when initializing your logger.

This line of logs seems more like debug info or tracing, but it shouldn't show up when using the info log level in my opinion.
I'm not super familiar with rust loggers, I went for env_logger and just set the global log level to info from the command line.
Maybe yes there are better solutions.

mgi388 pushed a commit to mgi388/Symphonia that referenced this issue May 10, 2024
core: change 'found the format marker' log message from info to debug
5973e6b 
Fixes pdeljanov#272
@mgi388 mgi388 linked a pull request May 10, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

core: change 'found the format marker' log message from info to debug mgi388/Symphonia
2 participants
@abique @pdeljanov