python3.11 breaks pdbpp -m

[monochromec]

Invoking Python 3.11 with -mpdb results in

Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/opt/homebrew/lib/python3.11/site-packages/_pdbpp_path_hack/pdb.py", line 5, in <module>
    exec(compile(f.read(), pdb_path, 'exec'))
  File "/opt/homebrew/lib/python3.11/site-packages/pdb.py", line 1306, in <module>
    pdb.main()
  File "/opt/homebrew/Cellar/python@3.11/3.11.2/Frameworks/Python.framework/Versions/3.11/lib/python3.11/pdb.py", line 1759, in main
    cls = _ModuleTarget if module_indicated else _ScriptTarget
                                                 ^^^^^^^^^^^^^
NameError: name '_ScriptTarget' is not defined

This problem can be reproduced on Ubuntu (22.04, Python 3.11.0) and Homebrew (with Python 3.11.2, see backtrace above). Please let me know if more info is required.

[blueyed]

This works with pdb++ from the master branch, please test it there.

[monochromec]

Installing this via setup.py install causes the egg directory to be stored in the corresponding site-packages directory but the _pdbpp_path_hack fails to be picked up correctly. Hence no pdb++ inclusion... What am I doing wrong?

Including this in PYTHONPATH as suggested by the README results in the issue as reported.

[blueyed]

Installation via pip should work (via local checkout (pip install …/pdpbb or pip install 'git+https://github.com/pdbpp/pdbpp@master').

[monochromec]

Unfortunately installing this via pip and the GH URL results in the same error reported initially. The _pdbpp_path_hackdirectory is created in site-packages but the pdb.py inclusion still fails. Please let me know if more info is required.

[blueyed]

Confirmed.

This fixes it, but likely needs checks to handle / skip it with older Pythons, and I am not sure if classes should be used as-is really:

 src/pdbpp.py | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git i/src/pdbpp.py w/src/pdbpp.py
index c64aa22..0022c5d 100644
--- i/src/pdbpp.py
+++ w/src/pdbpp.py
@@ -131,6 +131,10 @@ def rebind_globals(func, newglobals):
             _newfunc(func.func, newglobals), *func.args, **func.keywords
         )
 
+    if isinstance(func, type):
+        # Classes (_ModuleTarget, _ScriptTarget).
+        return func
+
     raise ValueError("cannot handle func {!r}".format(func))
 
 
@@ -2199,7 +2203,16 @@ def _remove_bdb_context(evalue):
     _usage = pdb._usage
 
 # copy some functions from pdb.py, but rebind the global dictionary
-for name in 'run runeval runctx runcall main set_trace'.split():
+for name in (
+    "run",
+    "runeval",
+    "runctx",
+    "runcall",
+    "main",
+    "set_trace",
+    "_ModuleTarget",  # Python 3.11
+    "_ScriptTarget",  # Python 3.11
+):
     func = getattr(pdb, name)
     globals()[name] = rebind_globals(func, globals())
 del name, func

[monochromec]

Confirmed that this fixes the issue on 3.11. Once it's entered pypi, I might do a regression on older Python versions.

[blueyed]

Let's keep the issue open until a fix is committed.

[jamilraichouni]

Don't know if it helps. When I pip install 'git+https://github.com/pdbpp/pdbpp@master' and then run some python -mpdb (...) with a Python 3.11.1 I see:

Traceback (most recent call last):                                                                                                                                                                                                                                               
  File "<frozen runpy>", line 198, in _run_module_as_main                                                                                                                                                                                                                        
  File "<frozen runpy>", line 88, in _run_code                                                                                                                                                                                                                                   
  File "/home/nörd/.pyenv/versions/rm-bridge-polarion/lib/python3.11/site-packages/_pdbpp_path_hack/pdb.py", line 17, in <module>                                                                                                                                                
    exec(compile(f.read(), pdb_path, 'exec'))                                                                                                                                                                                                                                    
  File "/home/nörd/.pyenv/versions/rm-bridge-polarion/lib/python3.11/site-packages/pdbpp.py", line 2328, in <module>                                                                                                                                                             
    pdbpp.main()                                                                                                                                                                                                                                                                 
  File "/home/nörd/.pyenv/versions/3.11.1/lib/python3.11/pdb.py", line 1759, in main                                                                                                                                                                                             
    cls = _ModuleTarget if module_indicated else _ScriptTarget                                                                                                                                                                                                                   
          ^^^^^^^^^^^^^                                                                                                                                                                                                                                                          
NameError: name '_ModuleTarget' is not defined

[tgy]

I get the same error! The patch fixes it.

[petobens]

Let's keep the issue open until a fix is committed.

@blueyed can you commit your patch? It seems to be working.

[tgy]

@petobens @blueyed see #520