GH-272 Improves annotation summary #273
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtache
force-pushed
the
annotationSummary
branch
from
bbce409
to
ac6154c
Compare
|
Do you think it would be possible to refactor the implementation to use RandomAccessFile instead of the wrapper FileSeekableStream? |
|
scrubber_annots.pdf |
added 5 commits
August 18, 2023 11:59
…ying annotation font size, retrieve annotation font size on popup init
pcorless
previously approved these changes
Nov 13, 2023
|
I have a bit more testing to do but will try and get this in this week. |
|
I replaced FileSeekableInputStream with BufferedInputStream, it should work without problems. |
|
Thanks. I was just testing with the file I posted above and I get a null pointer out the yCoordinates map in SummaryController. Is this still a draft pr? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #272
No actual implementation of import/export is available to avoid adding dependencies to the project just for this function.
Need to review / refactor this code given that it was developed 3 years ago.