GH-254 Set tighter permissions #255
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've given the PDF spec a good look over and I can't find anything specific to user permissions and annotation edits. There is an annotation flag for read-only but I don't see that being applicable here. I'm currently leaning towards not putting this behind a feature flag. If there is any push back from other library users, it can be reconsidered. |
gtache
force-pushed
the
modifyPermissions
branch
from
a639132
to
d89e2bf
Compare
…notationPopupMenu
pcorless
approved these changes
Nov 13, 2023
|
Just need to address these conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #254
Should we add an option / a flag to explicitly enable this option?
Also depends on #253