GH-252 Delete all annotations #253
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This feature feels like it should be behind a confirmation dialog, something like "8 Annotations will be deleted, are you sure?" Yes/no/cancel. Thoughts? |
|
That's a good comment yes, I'll add the dialog. |
|
Agreed, need to get back onto the undo/redo. |
…moveDocumentViewAnnotationComponent, use some convenience methods, re-add markup before popup to avoid some problems
|
The delete all action now allows undo/redo |
|
I think this will be good to go once the conflicts are resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #252
Depends on #271