Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] buttons style shape & loadScript result #490

Open
21stc-09 opened this issue May 9, 2024 · 4 comments
Open

[Bug] buttons style shape & loadScript result #490

21stc-09 opened this issue May 9, 2024 · 4 comments

Comments

@21stc-09
Copy link

21stc-09 commented May 9, 2024

Library used

paypal-js
version 8.0.2/8.0.5

🐞 Describe the Bug

1.function loadScript seems to return PayPalNamespace , but i cant use CardFields

2.There is no 'sharp' option for the shape field(buttons.d.ts/PayPalButtonsComponentOptions), but it is in the document, and 'sharp' option works.

🔬 Minimal Reproduction

😕 Actual Behavior

This is the result returned by loadScript
17152358634222

🤔 Expected Behavior

1.The first problem I want it return the object with CardFields, then i can use paypal && paypal.CardFields()
2.The second problem can be solve by ts-ignore,but i want to know whether you want to cancel the sharp option or just forget to update the type

🌍 Environment

  • Node.js/npm: v20.9.0 / 8.19.4
  • OS: Windows 10
  • Browser: Chrome 126.0.6452.3

➕ Additional Context

@21stc-09 21stc-09 changed the title [Bug] Bug report [Bug] buttons style shape & loadScript result May 9, 2024
@wsbrunson
Copy link
Member

for 1., can you share the options you are providing to loadScript?

@wsbrunson
Copy link
Member

wsbrunson commented May 20, 2024

  1. is definitely a bug, we actually have a ticket on our board to address this but we haven't gotten to it yet. I will link this issue to that ticket so once its deployed they will come back and update this issue.

@21stc-09
Copy link
Author

21stc-09 commented May 21, 2024

for 1., can you share the options you are providing to loadScript?

the first question is my mistake. our company account has not applied for the payment yet.
I think maybe you should make the conditions of use in your documentation a little more explicit. Before i get the solution I guessed it need to apply and then use it. but my leader said the document means it just need to open the option in the console. so i...

@21stc-09
Copy link
Author

  1. 绝对是一个错误,我们的董事会上实际上有一张票可以解决这个问题,但我们还没有得到解决。我会将此问题链接到该票证,因此一旦部署,他们将返回并更新此问题。

ok, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants