Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payload-Lexical: link tooltip pops up on selecting a decorator node #5909

Closed
vibhor-web-headout opened this issue Apr 18, 2024 · 1 comment · Fixed by #6241
Closed

Payload-Lexical: link tooltip pops up on selecting a decorator node #5909

vibhor-web-headout opened this issue Apr 18, 2024 · 1 comment · Fixed by #6241
Assignees
Labels
plugin: richtext-lexical @payloadcms/richtext-lexical [reproduced] If an issue has been reproduced

Comments

@vibhor-web-headout
Copy link

Link to reproduction

No response

Describe the Bug

Upon selecting a custom Decorator node, the tooltip for LinkNode displays and positions itself next to the Decorator node.
This does not happen for plain text present in lexical.

The selection seen in the Link Editor plugin, for this scenario, is a NodeSelection. It bypasses the flow mentioned here and relies on window selection to display the tooltip.

Screen.Recording.2024-04-18.at.3.08.52.PM.mov

To Reproduce

  1. Create a decorator node. This node should will not be editable.
  2. Add a command to mark the node as selected if anywhere inside the node is clicked.
  3. This should display the link tooltip below the decorator node.

Payload Version

2.11.2

Adapters and Plugins

@payloadcms/richtext-lexical: 0.7.0

@vibhor-web-headout vibhor-web-headout added the [possible-bug] Possible bug which hasn't been reproduced yet label Apr 18, 2024
@AlessioGr AlessioGr added [reproduced] If an issue has been reproduced plugin: richtext-lexical @payloadcms/richtext-lexical and removed [possible-bug] Possible bug which hasn't been reproduced yet labels May 6, 2024
@AlessioGr AlessioGr self-assigned this May 6, 2024
@AlessioGr AlessioGr linked a pull request May 6, 2024 that will close this issue
11 tasks
@AlessioGr
Copy link
Member

Fixed this in #6241 - will be available in the next 3.0 release! Do note that this likely won't get backported to 2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: richtext-lexical @payloadcms/richtext-lexical [reproduced] If an issue has been reproduced
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants