Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payara Micro command line option --hzconfigfile is stripping the full file path and only using the file name/FISH-8106 #6496

Open
paulmichaelhowell opened this issue Nov 30, 2023 · 1 comment
Assignees
Labels
Status: Accepted Confirmed defect or accepted improvement to implement, issue has been escalated to Platform Dev Type: Bug Label issue as a bug defect

Comments

@paulmichaelhowell
Copy link

Brief Summary

When I used the option --hzconfigfile /config/hazelcast-aws.xml, firstly the aws plugin we were using didn't work any more (that plugin was merged into hazelcast 5 at some point), but then I noticed this log message on startup:

Boot Command set returned with result SUCCESS : PlainTextActionReporterSUCCESSDescription: set AdminCommandnull
hazelcast-runtime-configuration.hazelcast-configuration-file=hazelcast-aws.xml

So as a workaround I didn't use --hzconfigfile, and used a preboot file with the following instead:

set hazelcast-runtime-configuration.hazelcast-configuration-file=/config/hazelcast-aws.xml

Then everything worked fine.

So I think in PayaraMicroImpl.java where it's creating the preboot command with alternateHZConfigFile, needs set the full path and filename, and not just the filename.

Expected Outcome

The log message should be showing the full path to the hazelcast config file, then I think it should all work e.g.

Boot Command set returned with result SUCCESS : PlainTextActionReporterSUCCESSDescription: set AdminCommandnull
hazelcast-runtime-configuration.hazelcast-configuration-file=/config/hazelcast-aws.xml

Current Outcome

Boot Command set returned with result SUCCESS : PlainTextActionReporterSUCCESSDescription: set AdminCommandnull
hazelcast-runtime-configuration.hazelcast-configuration-file=hazelcast-aws.xml

Reproducer

Run payara micro with the option such as --hzconfigfile /config/hazelcast-aws.xml

In the fixed version you would see log output such as:

Boot Command set returned with result SUCCESS : PlainTextActionReporterSUCCESSDescription: set AdminCommandnull
hazelcast-runtime-configuration.hazelcast-configuration-file=/config/hazelcast-aws.xml

Operating System

Amazon EC2 in ECS

JDK Version

Zulu JDK 17

Payara Distribution

Payara Micro

@paulmichaelhowell paulmichaelhowell added Status: Open Issue has been triaged by the front-line engineers and is being worked on verification Type: Bug Label issue as a bug defect labels Nov 30, 2023
@felixif
Copy link

felixif commented Nov 30, 2023

Hello @paumichaelhowell,

I have verified your report, and indeed, the --hzconfigfile command option is not recognising correctly the config XML file unless it is in the same folder as the Payara Micro jar file. Your workaround also worked as expected, and was added to my report. I have raised an internal issue FISH-8106, that our engineering team is going to start working on soon. Thank you very much for your report.

Thank you very much for your contribution!

Kind regards,
Felix Ifrim

@felixif felixif changed the title Payara Micro command line option --hzconfigfile is stripping the full file path and only using the file name. Payara Micro command line option --hzconfigfile is stripping the full file path and only using the file name/FISH-8106 Nov 30, 2023
@felixif felixif added Status: Accepted Confirmed defect or accepted improvement to implement, issue has been escalated to Platform Dev and removed Status: Open Issue has been triaged by the front-line engineers and is being worked on verification labels Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Confirmed defect or accepted improvement to implement, issue has been escalated to Platform Dev Type: Bug Label issue as a bug defect
Projects
None yet
Development

No branches or pull requests

2 participants