Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pet and Order status can get out of sync #309

Open
arosien opened this issue Jan 28, 2020 · 0 comments
Open

Pet and Order status can get out of sync #309

arosien opened this issue Jan 28, 2020 · 0 comments

Comments

@arosien
Copy link

arosien commented Jan 28, 2020

(sort of a design issue...)

Both Pet and Order have their own status which is updated independently. That is, nothing enforces they correspond, like OrderStatus.Delivered implies PetStatus.Adopted.

Some ideas to reconcile:

  • status: PetStatus could be removed from Pet altogether.
  • OrderService could update the PetRepository as necessary, and other methods to update the PetStatus could be limited.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant