New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
would look better with this style #2
Comments
You're right they do look better like that, but I kind of want to keep the flags true to their actual shape, I'll have a think about it. Yes I want people to contribute, if you want to help please fork and then make a pull request. |
why isn't the CSS written in a per-proccessor? it's an awful waste of time. I will submit mine with |
ok it's pretty much impossible to make my country's flag in pure CSS due to the fact that it might have 2 hollow triangles which have all 60 degree angels. this can be done with SVG easily..but not CSS. |
@yairEO I just sent a codepen with it (I assume you're from Israel) |
@gersht - what do you mean you just sent a codepen? sent where? please explain more. |
@yairEO in a separate issue http://codepen.io/gersht/pen/bNeRWV. |
I was trying to totally avoid that. having too much CSS beats the purpose of this game, since it could be done with SVG with much less code. drawing 3 separate lines and rotating them to create a hollow 60 degrees triangle was something I wanted to do. |
I can think of a few ways to css it. Creating two hollow triangles (like I did), drawing them as background-image using gradients instead of elements, or creating 6 hollow triangles and connecting them. I think I chose the most readable path. And I don't think it's a lot of CSS, or that it's complicated. |
Yeah it's not that complicated to do in CSS. Also @yairEO you're right SVG is a better technology to use, this repo is not necessarily the best real world use case its just about seeing what's possible with CSS. Hopefully people will learn something from the techniques used here and they'll be able to apply it to different things. |
Also, do you accept submitted flags?
The text was updated successfully, but these errors were encountered: