Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

would look better with this style #2

Open
yairEO opened this issue Dec 17, 2014 · 10 comments
Open

would look better with this style #2

yairEO opened this issue Dec 17, 2014 · 10 comments

Comments

@yairEO
Copy link

yairEO commented Dec 17, 2014

.flag{ border-radius:5px; overflow:hidden; box-shadow:0 0 10px #CCC; }

Also, do you accept submitted flags?

@pattle
Copy link
Owner

pattle commented Dec 17, 2014

You're right they do look better like that, but I kind of want to keep the flags true to their actual shape, I'll have a think about it. Yes I want people to contribute, if you want to help please fork and then make a pull request.

@yairEO
Copy link
Author

yairEO commented Dec 17, 2014

why isn't the CSS written in a per-proccessor? it's an awful waste of time. I will submit mine with SCSS and compiled to css. also I am wondering why would anyone would ever want to use such a graphic in CSS rather then SVG which is far more superior. I guess this project is more for fun than anything else. it is quite fun actually :)

@yairEO
Copy link
Author

yairEO commented Dec 17, 2014

ok it's pretty much impossible to make my country's flag in pure CSS due to the fact that it might have 2 hollow triangles which have all 60 degree angels. this can be done with SVG easily..but not CSS.

@gersht
Copy link

gersht commented Dec 18, 2014

@yairEO I just sent a codepen with it (I assume you're from Israel)

@yairEO
Copy link
Author

yairEO commented Dec 18, 2014

@gersht - what do you mean you just sent a codepen? sent where? please explain more.

@gersht
Copy link

gersht commented Dec 18, 2014

@yairEO in a separate issue http://codepen.io/gersht/pen/bNeRWV.

@yairEO
Copy link
Author

yairEO commented Dec 18, 2014

I was trying to totally avoid that. having too much CSS beats the purpose of this game, since it could be done with SVG with much less code. drawing 3 separate lines and rotating them to create a hollow 60 degrees triangle was something I wanted to do.

@gersht
Copy link

gersht commented Dec 18, 2014

I can think of a few ways to css it. Creating two hollow triangles (like I did), drawing them as background-image using gradients instead of elements, or creating 6 hollow triangles and connecting them. I think I chose the most readable path. And I don't think it's a lot of CSS, or that it's complicated.

@pattle
Copy link
Owner

pattle commented Dec 18, 2014

Yeah it's not that complicated to do in CSS. Also @yairEO you're right SVG is a better technology to use, this repo is not necessarily the best real world use case its just about seeing what's possible with CSS. Hopefully people will learn something from the techniques used here and they'll be able to apply it to different things.

@gersht
Copy link

gersht commented Dec 18, 2014

Also, @yairEO, I think (and @pattle correct me if I'm wrong here) we shouldn't be taking things TOO seriously here (with "beats the purpose of this game" and the like). It's just about using CSS to create flags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants