Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSS vars for breakpoints #6613

Closed
Tracked by #6587
mcoker opened this issue May 3, 2024 · 3 comments · Fixed by #6636
Closed
Tracked by #6587

Add CSS vars for breakpoints #6613

mcoker opened this issue May 3, 2024 · 3 comments · Fixed by #6636

Comments

@mcoker
Copy link
Contributor

mcoker commented May 3, 2024

We removed the CSS vars for breakpoints since we can't use them in @media queries, and left only the scss vars. We need to add those back since the react repo uses the CSS vars as a means to get the breakpoint values to do fancy pants scripty things like resize observer, and I imagine products may, too.

https://github.com/patternfly/patternfly-react/blob/029351e0fa402c80a6199e2bd4b28e8c06f17562/packages/react-core/src/components/Page/Page.tsx#L4C8-L4C26

https://github.com/patternfly/patternfly-react/blob/029351e0fa402c80a6199e2bd4b28e8c06f17562/packages/react-core/src/components/Page/Page.tsx#L163-L197

@srambach
Copy link
Member

srambach commented May 8, 2024

Also - let's see if they can be added as a token coming from Figma so they span design-dev.

@patternfly-build
Copy link

🎉 This issue has been resolved in version 6.0.0-alpha.128 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mcoker
Copy link
Contributor Author

mcoker commented May 10, 2024

closed via #6636

@mcoker mcoker closed this as completed May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants