Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patterns & Extensions: Remove UI Shell from figma variants #738

Closed
1 task
kaylachumley opened this issue May 14, 2024 · 2 comments
Closed
1 task

Patterns & Extensions: Remove UI Shell from figma variants #738

kaylachumley opened this issue May 14, 2024 · 2 comments
Assignees
Labels

Comments

@kaylachumley
Copy link
Collaborator

kaylachumley commented May 14, 2024

  • Pt 1: remove UI shell from extensions and patterns with page content.

Components/Patterns/Extensions that need added:

  • Dashboard
  • Catalog View
  • Card View

Pt 2 in a separate design issue

@kaylachumley
Copy link
Collaborator Author

kaylachumley commented May 23, 2024

done! This issue needs a pt 2 follow up. Lucia and I discussed adding variants or component swaps for the extensions within the page component so that would require another issue and a bit more thought on which approach is better long term. Currently we can at least detach the page body and drop the extension within the content area. @andrew-ronaldson

@andrew-ronaldson
Copy link
Contributor

Closed with follow up issue #739

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

2 participants