Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SGI reports wrong values if nan-values are present #742

Open
raoulcollenteur opened this issue Apr 16, 2024 · 0 comments
Open

SGI reports wrong values if nan-values are present #742

raoulcollenteur opened this issue Apr 16, 2024 · 0 comments
Assignees
@raoulcollenteur
Labels
bug Indicates an unintended behavior or coding error
Milestone
1.5

Comments

@raoulcollenteur
Copy link
Member

Describe the bug

For periods with nan-values in the head time series, the SGI method still returns values.

To Reproduce
ps.stats.sgi(head),. # a head ts with gaps

Expected behavior

ps.stats.sgi(head.dropna()),

Python package version
Python version: 3.11.3
NumPy version: 1.24.4
Pandas version: 2.1.4
SciPy version: 1.12.0
Matplotlib version: None
Numba version: 0.59.0
LMfit version: 1.2.2
Latexify version: Not Installed
Pastas version: 1.4.0
@raoulcollenteur raoulcollenteur added the bug Indicates an unintended behavior or coding error label Apr 16, 2024
@raoulcollenteur raoulcollenteur added this to the 1.5 milestone Apr 16, 2024
@raoulcollenteur raoulcollenteur self-assigned this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raoulcollenteur raoulcollenteur

Labels
bug Indicates an unintended behavior or coding error
Projects
None yet
Milestone
1.5
Development

No branches or pull requests
1 participant
@raoulcollenteur