Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENHANCEMENT] Add Ruff as linter and formatter #726

Open
4 tasks
martinvonk opened this issue Apr 9, 2024 · 1 comment
Open
4 tasks

[ENHANCEMENT] Add Ruff as linter and formatter #726

martinvonk opened this issue Apr 9, 2024 · 1 comment
Assignees
@dbrakenhoff @martinvonk
Labels
code quality Related to code quality, testing, CI, project setup etc. enhancement Indicates improvement of existing features priority 1 normal, deal with in the foreseeable future
Milestone
1.6

Comments

@martinvonk
Copy link
Collaborator

martinvonk commented Apr 9, 2024 •
edited

Describe the proposed enhancement
Add Ruff as linter

To do:

  • Can flake8 be removed as linter?
  • Can black be removed as formatter?
  • Can isort be removed as formatter?
  • Check if we can use github precommit such that each commit is automatically formatted.
@martinvonk martinvonk added enhancement Indicates improvement of existing features code quality Related to code quality, testing, CI, project setup etc. labels Apr 9, 2024
@martinvonk
Copy link
Collaborator Author

https://github.com/astral-sh/ruff-pre-commit

@martinvonk martinvonk changed the title [ENHANCEMENT] Add Ruff as linter [ENHANCEMENT] Add Ruff as linter and formatter Apr 9, 2024
@raoulcollenteur raoulcollenteur added this to the 1.5 milestone Apr 11, 2024
@martinvonk martinvonk added the priority 1 normal, deal with in the foreseeable future label Apr 12, 2024
@raoulcollenteur raoulcollenteur modified the milestones: 1.5, 1.6 Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbrakenhoff dbrakenhoff

@martinvonk martinvonk

Labels
code quality Related to code quality, testing, CI, project setup etc. enhancement Indicates improvement of existing features priority 1 normal, deal with in the foreseeable future
Projects
None yet
Milestone
1.6
Development

When branches are created from issues, their pull requests are automatically linked.

726-enhancement-add-ruff-as-linter-and-formatter pastas/pastas
3 participants
@dbrakenhoff @raoulcollenteur @martinvonk