Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update doc string Model.solve #544

Open
mbakker7 opened this issue Feb 10, 2023 · 2 comments
Open

Update doc string Model.solve #544

mbakker7 opened this issue Feb 10, 2023 · 2 comments
Assignees
@rubencalje
Labels
documentation Indicates a need for improvements or additions to documentation NWO priority 1 normal, deal with in the foreseeable future
Milestone
1.6

Comments

@mbakker7
Copy link
Collaborator

Request to update the doc string of Model.solve
In Model.solve, example of tmin is given as '1980'. Please specify whether this is the beginning or end of 1980.
By the same token, tmax is given as '2010'. Please specify whether this is the beginning of end of 2010.

Similar modifications may be needed for other functions that take a tmin or tmax.
@mbakker7 mbakker7 added the enhancement Indicates improvement of existing features label Feb 10, 2023
@mbakker7
Copy link
Collaborator Author

It seems that tmin=1980 means starting on 1/1/1980.
tmax='2010' gives values up to and including the first day of 2010.

@rubencalje
Copy link
Collaborator

Let's also include the time then: 1/1/1980 0:00.
So tmax = 2010 really is just up to 2010, as it is until 0:00 of januari 1st.

@martinvonk martinvonk added the priority 0 high, deal with as soon as possible label Mar 7, 2023
@martinvonk martinvonk added documentation Indicates a need for improvements or additions to documentation and removed enhancement Indicates improvement of existing features labels Mar 7, 2023
@raoulcollenteur raoulcollenteur modified the milestones: 1.2, 1.3 Aug 11, 2023
@raoulcollenteur raoulcollenteur modified the milestones: 1.3, 1.4 Nov 28, 2023
@raoulcollenteur raoulcollenteur modified the milestones: 1.4, 1.5 Feb 16, 2024
@raoulcollenteur raoulcollenteur changed the title [ENHANCEMENT] update doc string Model.solve Update doc string Model.solve Apr 9, 2024
@martinvonk martinvonk added NWO priority 1 normal, deal with in the foreseeable future and removed priority 0 high, deal with as soon as possible labels Apr 9, 2024
@raoulcollenteur raoulcollenteur modified the milestones: 1.5, 1.6 Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rubencalje rubencalje

Labels
documentation Indicates a need for improvements or additions to documentation NWO priority 1 normal, deal with in the foreseeable future
Projects
None yet
Milestone
1.6
Development

No branches or pull requests
4 participants
@mbakker7 @raoulcollenteur @rubencalje @martinvonk