Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve recharge models with implicit schemes #469

Open
raoulcollenteur opened this issue Jan 18, 2023 · 0 comments
Open

Solve recharge models with implicit schemes #469

raoulcollenteur opened this issue Jan 18, 2023 · 0 comments
Assignees
Labels
development Indicates development of new features priority 0 high, deal with as soon as possible
Milestone

Comments

@raoulcollenteur
Copy link
Member

Describe the proposed feature

The reservoirs from all the nonlinear recharge models are currently solved using explicit Euler scheme. Although this generally seems to work fine, it would be nice to add an option to use implicit schemes. I intend to implement this somewhere during 2023, after Pastas 1.0 is released.

Expected usage
I imagine the code would look like this. When creating a

rch = ps.rch.FlexModel(scheme="implicit")
sm = ps.RechargeModel(prec, evap, rfunc=ps.Exponential, recharge=rch) 

Additional context

It would be nice to see if we can come up with a single method that can be applied to all recharge models.

@raoulcollenteur raoulcollenteur added the development Indicates development of new features label Jan 18, 2023
@raoulcollenteur raoulcollenteur added this to the 1.1 milestone Jan 18, 2023
@raoulcollenteur raoulcollenteur self-assigned this Jan 18, 2023
@martinvonk martinvonk added the priority 2 low, nice to have feature to be implemented when time's available label Mar 7, 2023
@martinvonk martinvonk modified the milestones: 1.1, 1.2 Aug 3, 2023
@raoulcollenteur raoulcollenteur modified the milestones: 1.2, 1.3 Aug 11, 2023
@raoulcollenteur raoulcollenteur added priority 1 normal, deal with in the foreseeable future and removed priority 2 low, nice to have feature to be implemented when time's available labels Sep 4, 2023
@raoulcollenteur raoulcollenteur modified the milestones: 1.3, 1.5 Nov 28, 2023
@raoulcollenteur raoulcollenteur added priority 0 high, deal with as soon as possible and removed priority 1 normal, deal with in the foreseeable future labels Feb 20, 2024
@raoulcollenteur raoulcollenteur modified the milestones: 1.5, 1.6 Apr 12, 2024
@raoulcollenteur raoulcollenteur changed the title [Development] Solve recharge models with implicit schemes Solve recharge models with implicit schemes Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Indicates development of new features priority 0 high, deal with as soon as possible
Projects
None yet
Development

No branches or pull requests

2 participants