Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go Lint Errors #149

Open
furkanbegen opened this issue Oct 31, 2020 · 5 comments
Open

Go Lint Errors #149

furkanbegen opened this issue Oct 31, 2020 · 5 comments
Assignees
@yakuter @furkanbegen
Labels
Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity.
Projects
PassWall Roadmap

Comments

@furkanbegen
Copy link
Contributor

PaswallServer should pass all linter errors defined in golangci-lint package.
@furkanbegen furkanbegen changed the title Go Lint Error Go Lint Errors Oct 31, 2020
@furkanbegen furkanbegen mentioned this issue Oct 31, 2020
Closed
@yakuter yakuter added Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity. labels Oct 31, 2020
@yakuter yakuter added this to Accepted, Let's Develop! in PassWall Roadmap Oct 31, 2020
@yakuter
Copy link
Collaborator

yakuter commented Oct 31, 2020

Thank you @furkanbegen. I assigned you and me about this. Thank you for your support.

@mrtrkmn
Copy link
Contributor

mrtrkmn commented Nov 9, 2020

Super linter which is provided by Github could be quite efficient. Since it provides variety of lint options for a lot of environments and languages such as Dockerfile, ENV, CSS, GO, PHP and more.
Just a recommendation.

@furkanbegen furkanbegen mentioned this issue Dec 25, 2020
Closed
@yusufpapurcu
Copy link
Contributor

Maybe after fixing this linter errors, linter can add into github workflow. For decreasing linter errors in coming with new pull requests.

@furkanbegen
Copy link
Contributor Author

Maybe after fixing this linter errors, linter can add into github workflow. For decreasing linter errors in coming with new pull requests.

This make sense

@yakuter
Copy link
Collaborator

yakuter commented Mar 31, 2021

Thank you all for your comments. I used golangci-lint but want to give a chance to super linter. I will work on linter errors and then when they all finish I will add to github actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yakuter yakuter

@furkanbegen furkanbegen

Labels
Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity.
Projects
PassWall Roadmap
Accepted, Let's Develop!
Milestone
No milestone
Development

No branches or pull requests
4 participants
@yakuter @furkanbegen @mrtrkmn @yusufpapurcu