Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL in third line (without prefix, but with protocol) #562

Open
ltecheroffical opened this issue Feb 13, 2024 · 5 comments
Open

URL in third line (without prefix, but with protocol) #562

ltecheroffical opened this issue Feb 13, 2024 · 5 comments

Comments

@ltecheroffical
Copy link

Environment

Versions

  • Operating system: MacOS
  • Browser: Firefox 122.0.1
  • PassFF: 1.16
  • Host app: ???

Status line output: [hh:mm:ss] show -> (0)

Observations

  • Output of pass:
  • Your preferences
    • In PassFF:
    • In the host app passff.py:
  • Messages in the web console: (None)

When copying the password, everything seems fine until you copy the login info, as shown in the docs:

An entry like this is named "test"

Password123
Username

It is supposed to copy like this:

Password: Password123
Login: Username

However, the bug copies an entry with the same format as this:

Password: Password123
Login: test

Steps to reproduce the issue

  1. Create a simple entry with the username and password as usual but no labels
  2. Try to copy the login information using PassFF
  3. The login information should be the same as the entry name if done correctly.

Actual behaviour

What I get is details like this:

Password: Password123
Login: test

Expected behaviour

What's expected is details like these:

Password: Password123
Login: Username

@ltecheroffical
Copy link
Author

ltecheroffical commented Feb 13, 2024

Also the originization scheme requirement doesn't work well with single file because you can copy entire lines of entries but no one wants an output like this "URL: example.com"

@tuxor1337
Copy link
Collaborator

I can't reproduce the behavior that you described. Following your instructions I created an entry /test with the following contents:

Password123
Username

When I click on the entry in PassFF and select "Copy login", the token "Username" is copied to clipboard, as expected. I assume that you did not actually test your own instructions...?

Maybe your entry contains a line with a colon (":"). In that case, PassFF assumes that the entry follows the keyword-value format.

@ltecheroffical
Copy link
Author

After testing I found out it only breaks when there is a url at the bottom

@tuxor1337
Copy link
Collaborator

Yes, probably because the URL contains a colon, as I said and as is documented in the README:

If there are no colons (:) on any of the lines, and there are at least 2 lines, then the first two lines are assumed to contain the password and login name respectively:

@ltecheroffical
Copy link
Author

That does nuke the https:// ensuring a secure connection so maybe that oversight should be patched

@tuxor1337 tuxor1337 changed the title Password interpeted wrong URL in third line (without prefix, but with protocol) May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants