Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not display warning when pass is named with an IP address ± port #541

Open
bkazez opened this issue Jul 3, 2023 · 3 comments · May be fixed by #520
Open

Do not display warning when pass is named with an IP address ± port #541

bkazez opened this issue Jul 3, 2023 · 3 comments · May be fixed by #520

Comments

@bkazez
Copy link

bkazez commented Jul 3, 2023

Versions

  • Operating system: macOS 13.4 (22F66)
  • Browser: FF 114.0.2 (64-bit)
  • PassFF: 1.14.1

Description

Right now if you add an item like 192.168.3.4:3000 to pass, and try to autofill, it displays a warning saying that "There was an error parsing the URL (...) from the password database." If the URL is a valid IP address ± port, do not show this warning.

@tuxor1337
Copy link
Collaborator

tuxor1337 commented Jul 3, 2023

Thanks for the report!

Do you use the setting "Warn about potential phishing sites, such as when the domain listed in the database differs from that of the current page"? And did you set the "url" field inside the entry? Did you specify a protocol (e.g. https://)?

@bkazez
Copy link
Author

bkazez commented Jul 3, 2023

Warn about potential phishing sites

Yes.

Did you specify a protocol (e.g. https://)?

No. I just added a protocol and now I get two warnings: first, that the domain doesn't match (which is not correct), and second, that the protocol is insecure.

@tuxor1337 tuxor1337 linked a pull request May 22, 2024 that will close this issue
@tuxor1337
Copy link
Collaborator

This will be fixed once #520 is merged (the PR will add options to customize this behavior).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants