Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeated background image when style attribute is removed #534

Open
drtheuns opened this issue May 27, 2023 · 0 comments
Open

Repeated background image when style attribute is removed #534

drtheuns opened this issue May 27, 2023 · 0 comments

Comments

@drtheuns
Copy link

Environment

Working on a (localhost) Phoenix LiveView application (relevant, see below)

Versions

  • Operating system: Linux
  • Browser: Firefox 113.0.1 64bit
  • PassFF: 1.14.1
  • Host app: pass?

Status line output: otp -> (0) no error message

Observations

image

This happens when you hover over the input.

What I suspect happens:

  • Phoenix LiveView has 2 renders, the first as a regular HTTP response, then it starts a websocket and creates a "live" render.
  • On the first render, PassFF will add the icon to the input
  • On the second render, LiveView will remove the changes to the input element.
  • Now when you hover, it sets the background while the rest of the style attribute are missing.

Steps to reproduce the issue

  1. Load page, wait for PassFF to set the style on the input
  2. Remove the style inline attribute from the input element
  3. Hover over the input

Actual behaviour

The fill icon is repeated as background

Expected behaviour

The fill icon is only shown once

Maybe the onIconHover and similar functions should set all the style attributes instead of only the background-image and cursor?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants