Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Package for nix #51

Closed
pbek opened this issue Apr 16, 2024 · 6 comments
Closed

[feature request] Package for nix #51

pbek opened this issue Apr 16, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@pbek
Copy link

pbek commented Apr 16, 2024

It would be great to have a package for Nix.

So I created one, if anyone wants to test:
NixOS/nixpkgs#304480

@pbek pbek added the bug Something isn't working label Apr 16, 2024
@speatzle
Copy link
Collaborator

Hi, thanks for packaging!

From Looking at the Package File, i can see that you set the LD Flag for version but not for commit or date. It will work this way but will show unknown for both of those in the version flag's output, you can set them like goreleaser (https://goreleaser.com/cookbooks/using-main.version).

Also go-passbolt-cli has man pages which i don't see included, you can generate the man pages using mkdir man && passbolt gendoc --type man and then move them to the correct place.

Ill see about setting up a NixOS Install SoonTM to actually test the package.

@speatzle speatzle added enhancement New feature or request and removed bug Something isn't working labels Apr 16, 2024
@speatzle
Copy link
Collaborator

Also since this is a Community Project, i don't know if we want to set the homepage to https://www.passbolt.com. Id rather set it to this GitHub Repo.

@pbek
Copy link
Author

pbek commented Apr 16, 2024

Thank you for the feedback!

From Looking at the Package File, i can see that you set the LD Flag for version but not for commit or date. It will work this way but will show unknown for both of those in the version flag's output, you can set them like goreleaser (https://goreleaser.com/cookbooks/using-main.version).

I didn't see a clear way what to be set in nixpkgs, most go packages just don't use these flags or fake some. I can fake some information too...

Also go-passbolt-cli has man pages which i don't see included, you can generate the man pages using mkdir man && passbolt gendoc --type man and then move them to the correct place.

Nice, thank you!

Also since this is a Community Project, i don't know if we want to set the homepage to https://www.passbolt.com. Id rather set it to this GitHub Repo.

Of course!

@pbek
Copy link
Author

pbek commented Apr 16, 2024

I did changes to https://github.com/NixOS/nixpkgs/pull/304480/files.
Happy nix-install. 😊

@pbek
Copy link
Author

pbek commented Apr 16, 2024

I showed the output for man-pages and the shell-completion here:

NixOS/nixpkgs#304480 (comment)

@pbek
Copy link
Author

pbek commented May 15, 2024

@pbek pbek closed this as completed May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants