Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create welcome message to users that join the Discord #25

Open
maxcell opened this issue Sep 4, 2020 · 9 comments · May be fixed by #33
Open

Create welcome message to users that join the Discord #25

maxcell opened this issue Sep 4, 2020 · 9 comments · May be fixed by #33

Comments

@maxcell
Copy link
Contributor

maxcell commented Sep 4, 2020

Instead of the server-generated message, we could have our bot do a more customized and more computer enthusiast-esque intros.

Some considerations:

  • Should we at mention them when they join?
  • How to make the list of welcomes to select from

Edit: Documentation for us around when a guild member joins the server

@M0nica
Copy link

M0nica commented Sep 4, 2020

Have we decided how to handle the default messages? My understanding is custom messages would be in addition to the default messages. I know there was convo about having a separate locked channel for the default messages.

@maxcell
Copy link
Contributor Author

maxcell commented Sep 4, 2020

For context, this is referring to these joined server messages.
Screen Shot 2020-09-04 at 9 38 42 AM

What you mention is also a problem to address definitely. When you're referring to default messages vs. custom messages, could you elaborate more about what those mean to you @M0nica? I assume you mean like default message of like "how to use this discord" similar to what we have in #welcome but potentially like you said we were considering doing things like private channels with the folks?

@M0nica
Copy link

M0nica commented Sep 4, 2020

When I said default messages I was referring to waht you sent in the screenshot. I haven't looked into the discord message API so wasn't sure if there's a way to actually change the copy of those messages or if the welcome messages would technically be additive. But if it's possible to actually modify those messages than my comment is a moot point.

@maxcell
Copy link
Contributor Author

maxcell commented Sep 4, 2020

I think we can't modify those messages, but I was gonna suggest turning them off the default messages and running custom only. I think that's the closest it can get from some research. At least this way we could have an ever-running list of them.
image

@maxcell
Copy link
Contributor Author

maxcell commented Sep 4, 2020

Interesting 🤔 . I also don't think that the boost event can be handled beyond when the message comes. Can't find it in serenity or Discord. I was thinking of potentially giving that to the bot so we could split that if we wanted.

@mdarrik
Copy link
Contributor

mdarrik commented Sep 4, 2020

Since Chris deleted, it's worth noting that boost messages go to the same channel as welcome if we push the random messages to a private channel. So we'd want to send custom boost messages too in that case.

@ChristopherBiscardi
Copy link
Contributor

ChristopherBiscardi commented Sep 4, 2020

ah good call @mdarrik
I wonder what boost messages/webhooks/events look like

@maxcell
Copy link
Contributor Author

maxcell commented Sep 4, 2020

Basically came to the same conclusion this thread ran to for handling boost discordjs/discord.js#3359 (comment) TL;DR: we basically listen to guild member update (another handler) check against if their premium since isn't null. The only caveat I think that isn't caught there though is what if I'm a user who has already has boosted? Maybe check for a time range of a few seconds?

I wish this was an easy thing to test but haven't investigated what options there are either.

@mdarrik
Copy link
Contributor

mdarrik commented Sep 4, 2020

Looking at that thread, it looks like there's a message type for boost messages. So I don't think that would be a problem if we go the private/mod-only channel route for the default welcome messages.

We also only get messages currently for initial boost. So I don't know that we have to worry about boost renewals just yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants