-
-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a fixed environment container (with docker for e.g.) to support starting developers or testers. #1071
Comments
There is a docker container managed by mhubig. Although I'd like to see it be under official namespace of partkeepr. But this is merely for production and not for development. One problem is that there needs to be a way to run the setup without calling a set of web sites. This is needed as (at the moment according to my understanding) nobody except for @Drachenkaetzchen knows exactly what happens during setup routine. This needs to be done manually in order to make automated builds and tests possible. |
It would be much more convinient to do a
|
Well, the code is there. Also, all setup does is to generate the |
Well, that is a good source of information. Thank you for the hint @Drachenkaetzchen. |
Just a small question at @Drachenkaetzchen and @dromer. Where would we put such files? Some repos I have seen use a subfolder, other use a complete own repo for all sort of CI/CD. What would be your preference for partkeepr? Maybe I can do something here but I want to avoid make the work twice. |
I agree with @shafr that a simple docker and/or docker-compose file should be enough to get going. However it is important that there is a volume mounted for any assets and cache that partkeepr needs. Usually everything is self-contained with docker, but in this case a mounted volume is quite necessary. |
@christianlupus I think a dockerfile in the root should be fine. Unless it becomes a 'collection' of files then a subdir to keep it a bit neater. |
Well using docker image for composer:1.9.3 causes issues with packages:
I'm not sure how Seems like that
and use it as builder. |
At the moment I am working on a patch in my personal fork. Yesterday I successfully installed it but found that the GitHub Packages docker system does not provide anonymous access to public packages (See this discussion). So I need to rework things a bit. There are still some open things to do but especially I do not (yet) have a database dump to import in case of development to have some dummy entries. |
I managed to get "something" running. As soon as I commit something to my @dromer Do you prefer to have a clean history in a potential PR or are you going to squash anyways? Otherwise I have to rework my branch history 😏. |
Depending on the amount of lines we can squash it (if it's just a concise config or 2 that would be fine). |
No squash is needed - rather use multi-stage builds |
@shafr we where talking about git commits. and also I don't see how multi-stage Dockerfile is relevant here. |
@Drachenkaetzchen To have a more detailed docker image, I'd like to add quite some testing data there. Would you be ok, if we added the test data from the demo page there? Of course, we would remove your personal account from the SQL dump to avoid any leaking of password hashes and replace it by something general (that can be published). |
The demo site is already cleaned out of personal data I think. Do you have access to the dump? |
Unfortunately neither to the SQL dump nor to a file system dump of the |
Here are the sql dump and the data files: https://cloud.drachenkatze.org/index.php/s/6WJWp9t9qRqwzrx |
Thank you, I downloaded the files. Are you keeping the link open in the future? Otherwise you can close it now. |
No, I don't have a huge amount of disk space so I'll remove it now. |
@christianlupus Did you succeed in making a working docker image? |
We shall provide an easy to use environment and also a reference environment to support testing and developing. Common used tasks shall be made easy accessible for e.g. using a shell script or similar thing. For e.g. the following stuff shall be possible:
I suggest to make a docker container for this stuff.
The text was updated successfully, but these errors were encountered: