Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadow the ANTLRv4 runtime dependency to avoid conflicts. #1407

Open
RCHowell opened this issue Apr 1, 2024 · 0 comments
Open

Shadow the ANTLRv4 runtime dependency to avoid conflicts. #1407

RCHowell opened this issue Apr 1, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@RCHowell
Copy link
Contributor

RCHowell commented Apr 1, 2024

Relevant Issue/Bug

The partiql-parser package uses the ANTLRv4 runtime (4.10.x) which conflicts with other projects that require different minor versions of this dependency. A reasonable solution is to shade (aka re-package) this dependency.

Requested Solution/Feature

The partiql-parser repackages the antlr runtime dependency so customers who need to consume an incompatible minor version of it can consume both.

Describe Alternatives

  • jarjar
  • shadow
  • vend the runtime internally + ctrl+f/r generated-src (perhaps too hacky)

Additional Context

N/A

DoD (Definition of Done)

  1. The partiql-parser library does not have an antlr runtime dependency*
  2. The antlr runtime dependency is shadowed (aka move the package name to avoid conflicts)
  3. The generated sources use the shaded names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant