Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build_header function missing in bin/list-all #1

Closed
joschi opened this issue May 19, 2021 · 2 comments · Fixed by #3
Closed

build_header function missing in bin/list-all #1

joschi opened this issue May 19, 2021 · 2 comments · Fixed by #3

Comments

@joschi
Copy link

joschi commented May 19, 2021

The bin/list-all script is missing the build_header function, leading to the following error when running asdf list-all yadm:

Plugin yadm's list-all callback script failed with output:
/home/runner/.asdf/plugins/yadm/bin/list-all: line 14: build_header: command not found

The build_header function exists in the bin/download script:

asdf-yadm/bin/download

Lines 45 to 50 in f268195

build_header() {
local key=${1}
local val=${2}
echo "'$key: $val'"
}

Refs asdf-vm/asdf#881

joschi added a commit to joschi/asdf-vm-twitter that referenced this issue May 19, 2021
```
Plugin yadm's list-all callback script failed with output:
/home/runner/.asdf/plugins/yadm/bin/list-all: line 14: build_header: command not found
```

Refs particledecay/asdf-yadm#1
@particledecay
Copy link
Owner

Fixed in #2. Thanks for the issue report!

@joschi
Copy link
Author

joschi commented May 20, 2021

@particledecay Unfortunately it still doesn't work because the build_header function is defined after its first usage if $OAUTH_TOKEN is set.

# OAUTH_TOKEN=1 bin/list-all
bin/list-all: line 14: build_header: command not found

particledecay added a commit that referenced this issue Jun 7, 2021
Remove the `build_header` function, as it's no longer needed for a
single header definition.

fixes #1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants