Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster pgen Cleanup #46

Open
2 of 4 tasks
forrestglines opened this issue Mar 28, 2023 · 1 comment
Open
2 of 4 tasks

Cluster pgen Cleanup #46

forrestglines opened this issue Mar 28, 2023 · 1 comment

Comments

@forrestglines
Copy link
Contributor

forrestglines commented Mar 28, 2023

We identified a few aspects of the cluster setup in #2 that could be cleaned up, although they are low priority

  • Unify the calculation mean molecular masses from helium mass fraction
  • Simplify/avoid the passing around of hydro_pkg for the different cluster functions
  • k_0 and k_100 have bad orders of magnitude, <-100. This could be partially rectified by dividing these quantities by mean particle mass
  • Make determining the radial points where the 1D HSE profile is integrated more robust without the r_sampling parameter
@pgrete
Copy link
Contributor

pgrete commented Aug 7, 2023

  • check source term handling of (updated) prims and cons
  • add safety check for floors and ceilings so that a negative values translate to deactivate
  • document (cluster) floors/ceilings
  • use periodic bounds for default cluster pgen
  • (optional) extend init to MeshData (@forrestglines : "the HSE profile piece would be the trickiest to extend to multiple meshblocks instead of just one meshblock. But not that hard, you would just need to integrate a profile that extends all SMR levels")
  • add option to specify length scale instead of wavenumber for initial perturbation
  • add safety check so that jet thickness matches resolution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants