Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shock flattener #21

Open
pgrete opened this issue Feb 14, 2023 · 1 comment
Open

Add shock flattener #21

pgrete opened this issue Feb 14, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@pgrete
Copy link
Contributor

pgrete commented Feb 14, 2023

@BenWibking reported on https://gitlab.com/theias/hpc/jmstone/athena-parthenon/athenapk/-/issues/14:

It would be very useful to implement the shock flattener from Miller & Colella (2002): https://ui.adsabs.harvard.edu/abs/2002JCoPh.183...26M/abstract

Thread:

@pgrete FYI (not sure if you've seen it), first order flux correction is implemented to fix troubled cells.
@BenWibking Yes, I've seen that. In my tests with Quokka, the shock flattener appeared necessary to suppress some post-shock oscillations in strong shocks. I remember this being a particular issue with the Zel'dovich spike in radiative shocks. Do you see any of these kinds of issues currently? I didn't do characteristic reconstruction in Quokka, so that might be a difference.

@pgrete I see. I didn't think of the post-shock oscillations. For those the flattener might be the better choice.

@BenWibking Is first-order flux correction implemented for RK2/RK3?

@pgrete We call first order flux correction in each stage at the moment (so not just at the very end). I'm not sure which is the better approach, but I went for this one as I think that "each stage" might be better because no neighboring cells will be updated during an entire cycle with potentially nonphysical data from a previous stage.
@BenWibking That's what I did in Quokka as well. If I didn't do this at the end of each stage, then in the later stages, the Riemann solver would produce NANs from the imaginary sound speeds. So this makes sense to me.

@BenWibking The oscillations can also be reproduced with a pure-hydro shock tube, such as this one: https://github.com/BenWibking/quokka/blob/development/src/HydroShocktube/test_hydro_shocktube.cpp based on this test problem: https://cococubed.com/code_pages/ppm_1d.shtml

@pgrete pgrete added the enhancement New feature or request label Feb 14, 2023
@BenWibking
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants