Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database Password Security Check Doesn't Check All Possible URIs #8833

Open
sjmckee opened this issue Dec 12, 2023 · 2 comments · May be fixed by #9078
Open

Database Password Security Check Doesn't Check All Possible URIs #8833

sjmckee opened this issue Dec 12, 2023 · 2 comments · May be fixed by #9078
Labels
bounty:$10 Bounty applies for fixing this issue (Parse Bounty Program) type:feature New feature or improvement of existing feature

Comments

@sjmckee
Copy link

sjmckee commented Dec 12, 2023

const databaseUrl = databaseAdapter._uri;

Would it be beneficial to also look for config.databaseURI if a database adapter is not defined in the configuration object? I do not currently have a database adapter defined in my config (using Postgresql), and when I access the new /security endpoint, it informs me my password does not meet the minimum requirements. However, it does meet the minimum requirements specified in CheckGroupDatabase.js.

Here is an example that will fail the database password security check when only config.databaseURI is specified, but it should pass:

    export const config = {  
        databaseURI: 'postgres://mypostgresuser:q00A1qgxYNHzn2ID5XST@localhost:5432/parse'
        ...  
    }
Copy link

Thanks for opening this issue!

@mtrezza mtrezza added type:feature New feature or improvement of existing feature bounty:$10 Bounty applies for fixing this issue (Parse Bounty Program) labels Dec 13, 2023
@userAdityaa
Copy link

Hello, I am new to contributing. Can you please give me some more explanation to this problem. It seems i can work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty:$10 Bounty applies for fixing this issue (Parse Bounty Program) type:feature New feature or improvement of existing feature
Projects
None yet
3 participants