GraphQL schema name collision caused by autogenerated Order input parameter

[ThunbergOlle]

New Issue Checklist

• I am not disclosing a vulnerability.
• I am not just asking a question.
• I have searched through existing issues.
• I can reproduce the issue with the latest version of Parse Server.

Issue Description

When autogenerating the GraphQL schema, Parse creates input types for each class. All the generated input types has a trailing Input word. Except for the Order input type. Meaning that if you have a class called Item the sorting input type will be called ItemOrder

This becomes problematic since it is common, when for example, building e-commerce sites, to have collections ending with "Order" (as in buy-order). ItemOrder, GiftCardOrder etc.

Because of this, if you have two classes called Item and ItemOrder it will cause a name collision in the schema. The result of this being that ItemOrder (the collection) defaults its type to Object causing an error when trying to access its collection properties through the GraphQL API.

Here is an example of how creating a class called Item reserving the type name ItemOrder

items(
where: ItemWhereInput
order: [ItemOrder!]
skip: Int
after: String
first: Int
before: String
last: Int
options: ReadOptionsInput
): ItemConnection!

If we also have a ItemOrder collection, it logs this warning:

warn: Type ItemOrder could not be added to the auto schema because it collided with an existing type.

And the type for the ItemOrder (collection) query is:

itemOrder(
id: ID!
options: ReadOptionsInput
): Object

Steps to reproduce

1. Create a new parse project with GraphQL
2. Create a class called Item
3. Create a class called ItemOrder

Solutions

A potential solution is to follow the naming conventions parse already uses for the other input types. Meaning that we can add Input to the end.

Example:

items(
where: ItemWhereInput
order: [ItemOrderInput!]
skip: Int
after: String
first: Int
before: String
last: Int
options: ReadOptionsInput
): ItemConnection!

It should be noted that this is a breaking change if the input type is being used as follows:

query myQuery($order: [ItemOrder!]){
  items(order: $order){
    count
  }
}

This would have to be changed to this:

query myQuery($order: [itemOrderInput!]){
  items(order: $order){
    count
  }
}

[parse-github-assistant]

Thanks for opening this issue!

• 🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.