Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard scrolls when selecting row in data browser #2545

Closed
4 tasks done
mtrezza opened this issue Apr 19, 2024 · 5 comments · Fixed by #2559
Closed
4 tasks done

Dashboard scrolls when selecting row in data browser #2545

mtrezza opened this issue Apr 19, 2024 · 5 comments · Fixed by #2559
Labels
bounty:$20 Bounty applies for fixing this issue (Parse Bounty Program) type:bug Impaired feature or lacking behavior that is likely assumed

Comments

@mtrezza
Copy link
Member

mtrezza commented Apr 19, 2024

New Issue Checklist

Issue Description

Dashboard scrolls when selecting row in data browser. This has only been observed when a filter is set.

Uploading recording.mov…

Steps to reproduce

  1. Open dashboard collection in data browser; collection needs to be large enough so it contains enough rows to scroll multiple pages; e.g. see screen recording which uses 300 rows.
  2. Set filter "objectId exists".
  3. Select a row without scrolling down.
  4. Scroll down at least 2 pages and select a row --> data browser jump-scrolls up.

Environment

Dashboard

  • Parse Dashboard version: 6.0.0-alpha.1
  • Browser (Safari, Chrome, Firefox, Edge, etc.): Safari
  • Browser version: Version 17.4.1 (19618.1.15.11.14)
Copy link

parse-github-assistant bot commented Apr 19, 2024

Thanks for opening this issue!

  • 🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.

@mtrezza mtrezza added type:bug Impaired feature or lacking behavior that is likely assumed bounty:$20 Bounty applies for fixing this issue (Parse Bounty Program) labels Apr 19, 2024
@devbymak
Copy link
Contributor

devbymak commented May 7, 2024

I tried doing steps but didn't see jump-scrolls up, can you upload the record?

@mtrezza
Copy link
Member Author

mtrezza commented May 10, 2024

Sometimes I can't get it to replicate neither. I believe it has something to do with:

  • how many items are filtered out in between the visible rows
  • the scroll position you are at when you set the filter
  • maybe something in the cache

You'd have to play around a bit.

  1. Create class "Test".
  2. Open the JS console and run:
    const objs = [];
    
    for (let i=0; i<1000; i++) {
      const obj = new Parse.Object('Test');
      objs.push(obj);
    }
    
    await Parse.Object.saveAll(objs);
  3. Set filter "objectId exists".
  4. Select individual rows --> view scrolls

I'll post a comment if I managed to pin it down.

@devbymak
Copy link
Contributor

Actually, I realized that when a cell is selected and we scroll down to select a row, the row isn't properly selected(selected objectId is different), and the scroll jumps back up. Is that correct?

@mtrezza
Copy link
Member Author

mtrezza commented May 13, 2024

Yes that sounds like the issue I tried to describe here. It seems to be difficult to reproduce with only a few rows in a class, although I managed to do it sometimes with only 100 - 1k rows. But it occurs reliably in classes with a large number of rows and a filter set.

Could you share a video of what you observed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty:$20 Bounty applies for fixing this issue (Parse Bounty Program) type:bug Impaired feature or lacking behavior that is likely assumed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants