Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facebook and Twitter login are creating a new column called "name" #145

Open
Ricardo1980 opened this issue Feb 4, 2017 · 3 comments
Open

Comments

@Ricardo1980
Copy link
Contributor

Hello,

When login with facebook or twitter, ParseLoginFragment is creating a new column in the object User called "name".
https://github.com/ParsePlatform/ParseUI-Android/blob/master/ParseUI-Login/src/main/java/com/parse/ui/ParseLoginFragment.java#L350

In my opinion this is wrong, because it is not normal creating a column if the programmer does not want.
Apart from that, the iOS version does not do that, as you can see here:
https://github.com/ParsePlatform/ParseUI-iOS/blob/master/ParseUI/Classes/LogInViewController/PFLogInViewController.m#L320

In other others, logic in iOS and Android should be aligned.

I already modified the library removing that extra logic. Do you want a pull request? Is there anyone maintaining this library?

Thanks.

@Toofoo
Copy link

Toofoo commented Jun 7, 2017

where will you store the facebook / twitter displayName ?

@Ricardo1980
Copy link
Contributor Author

In the same place the iOS library is saving it: Nowhere.

The library should not do something the programmer didn't ask, without mentioning that it could let your database in an inconsistent state, given that it could fail for some users, and work perfectly for others (we don't have transactions in Parse, as far as I remember).
And, as said, iOS is not doing that. So, depending if you are using android or iOS your data in your database would be different.

@Toofoo
Copy link

Toofoo commented Jun 7, 2017

I think the best should be a configuration parameter (like Android Manifest Meta Data) to allow to store (or not) the profile name from thrid provider (FaceBook, Twitter), same for the "photoUrl". this could be parameterized in android and IOS as well if someone could make the modification code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants