Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate this repo and integrate as module in Parse Android SDK #112

Open
mtrezza opened this issue Jun 18, 2020 · 5 comments
Open

Deprecate this repo and integrate as module in Parse Android SDK #112

mtrezza opened this issue Jun 18, 2020 · 5 comments

Comments

@mtrezza
Copy link
Member

mtrezza commented Jun 18, 2020

Issue

This repo depends on the Parse Android SDK and changes in there can break this repo. One example is the transition to the internalized bolts dependency parse-community/Parse-SDK-Android#1036.

Solution

Deprecate this repo and integrate it as a module in the Parse Android SDK for better testing and dependency checking.

@mtrezza mtrezza changed the title Move repo as module to Parse Android SDK Integrate repo as module in Parse Android SDK Jun 18, 2020
@mtrezza mtrezza changed the title Integrate repo as module in Parse Android SDK Deprecate this repo and integrate as module in Parse Android SDK Jun 18, 2020
@Jawnnypoo
Copy link
Member

Makes sense. Feel free to tackle this if you'd like.

@mtrezza
Copy link
Member Author

mtrezza commented Jun 18, 2020

I wonder if there was a reason why it has not been created as a module in the first place

@Jawnnypoo
Copy link
Member

I don't think there was a reason other than the fact that different people were working on each project.

@mmimeault
Copy link
Contributor

There was no specific reason.
The iOS livequery was also in is own repo. And every other "feature/plugin/project" has its own repo in the parse-community org.

I think it's a question of opinion. Having a separate repo also allow the project to have its own "issue" and PR.

@mtrezza
Copy link
Member Author

mtrezza commented Jun 18, 2020

For separation we could just use labels. I think merging the few issues and PRs into the "main" SDK would actually give more oversight and prevent dependency issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants