Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ParseConstants for visionOS support. #450

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

misteu
Copy link

@misteu misteu commented Feb 11, 2024

New Pull Request Checklist

Issue Description

Updates ParseConstants as the SDK currently cannot be built when imported and tried to be built against visionOS target

Closes: #449

Approach

Adds visionOS platform to ParseConstants.

	#elseif os(visionOS)
	static let deviceType = "visionos"

TODOs before merging

  • Add tests
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

Copy link

parse-github-assistant bot commented Feb 11, 2024

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@misteu misteu changed the title Ipdated ParseConstants for visionOS support. Updated ParseConstants for visionOS support. Feb 11, 2024
@mtrezza mtrezza requested review from a team and removed request for a team February 26, 2024 19:31
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.42%. Comparing base (3d4bb13) to head (9064c2f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #450      +/-   ##
==========================================
- Coverage   90.37%   87.42%   -2.95%     
==========================================
  Files         161      161              
  Lines       16267    16208      -59     
==========================================
- Hits        14701    14170     -531     
- Misses       1566     2038     +472     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not build against visionOS target
1 participant