Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: SafeParseDelegate ignores name parameter on setValue #1199

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: SafeParseDelegate ignores name parameter on setValue #1199

wants to merge 1 commit into from

Conversation

augustocarmo
Copy link

@augustocarmo augustocarmo commented Sep 21, 2023 •
edited

New Pull Request Checklist

Issue Description

When a variable used the safeAttribute(String) function, the setValue (from the SafeParseDelegate) was not working properly when its name was different from the name param from the delegate because the name param was being ignored.

Closes: #1200

Approach

Consider the SafeParseDelegate's name param that is passed via constructor as it's done to ParseDelegate.

image

@parse-github-assistant
Copy link

parse-github-assistant bot commented Sep 21, 2023 •
edited

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@augustocarmo augustocarmo changed the title fix(delegates): ParseDelegate was ignoring the name param on setValue fix(delegates): SafeParseDelegate was ignoring the name param on setValue Sep 21, 2023
@mtrezza mtrezza changed the title fix(delegates): SafeParseDelegate was ignoring the name param on setValue fix: SafeParseDelegate ignores name parameter on setValue Sep 22, 2023
mtrezza
mtrezza requested changes Sep 22, 2023
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test?

@mtrezza mtrezza requested a review from a team September 22, 2023 01:25
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f9843c5) 0.00% compared to head (e7db68b) 0.00%.
Report is 2 commits behind head on master.

Additional details and impacted files 
@@          Coverage Diff           @@
##           master   #1199   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         122     122           
  Lines        9971    9971           
  Branches     1345    1345           
======================================
  Misses       9971    9971

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SafeParseDelegate's name param being ignored on setValue function
3 participants
@augustocarmo @mtrezza @augusto-carmo-mesa