Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 1.8 compile option unnecessary since Gradle 7 #1160

Open
3 tasks done
mobilekosmos opened this issue Apr 16, 2022 · 5 comments
Open
3 tasks done

Java 1.8 compile option unnecessary since Gradle 7 #1160

mobilekosmos opened this issue Apr 16, 2022 · 5 comments

Comments

@mobilekosmos
Copy link

New Feature / Enhancement Checklist

Following block in all build.gradle files is not needed anymore since using Gradle 7 because implicitly defined:
compileOptions {
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8
}

Can be removed.

@mtrezza
Copy link
Member

mtrezza commented Apr 16, 2022

Do you want to open a PR for this?

Can you please add a reference link to an official resource that states the exact version since when Java 1.8 is used by default?

@mtrezza mtrezza changed the title compileOptions{} declaration not needed anymore since Gradle 7 Java 1.8 compile option unnecessary since Gradle 7 Apr 16, 2022
@parse-github-assistant
Copy link

Thanks for opening this issue!

  • ❌ Please edit your post and use the provided template when creating a new issue. This helps everyone to understand your post better and asks for essential information to quicker review the issue.

@mobilekosmos
Copy link
Author

mobilekosmos commented Apr 16, 2022

https://developer.android.com/studio/releases/gradle-plugin?hl=nl#java-8-default
I also tried it in the past, before Gradle 7 you got a compiler error if I remember correctly if you didn't have that block in the gradle file, with Gradle 7 you don't get any error or warning when removing it.

@mtrezza
Copy link
Member

mtrezza commented Apr 16, 2022

Is this only relevant for when compiling the Parse Android SDK, or also for developers who add the SDK as a dependency?

@azlekov
Copy link
Contributor

azlekov commented Apr 16, 2022

@mtrezza it's mostly relevant for this SDK as we do not know which version the users will use. Most probably all users already uses Gradle 7 and latest Android toolchains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants