Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to configure max cache size and and count for ParseKeyValueCache #1098

Open
evtimmy opened this issue Aug 6, 2021 · 0 comments
Labels
type:feature New feature or improvement of existing feature

Comments

@evtimmy
Copy link

evtimmy commented Aug 6, 2021

Right now ParseKeyValueCache has two configuration variables, but those have package visibility and can't be changed from the app.

The current config variables default to 2MB and 1000 requests:

    /* package */ static int maxKeyValueCacheBytes = DEFAULT_MAX_KEY_VALUE_CACHE_BYTES;
    /* package */ static int maxKeyValueCacheFiles = DEFAULT_MAX_KEY_VALUE_CACHE_FILES;

Simplest way is to expose these as public, but perhaps a better configuration API could be devised? Something along the lines of:

public static configure(maxSizeInBites, maxQueryCount)
@mtrezza mtrezza added type:feature New feature or improvement of existing feature and removed type:improvement labels Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature or improvement of existing feature
Projects
None yet
Development

No branches or pull requests

2 participants