Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing self in readme example #41

Open
bnomei opened this issue Sep 1, 2019 · 0 comments
Open

missing self in readme example #41

bnomei opened this issue Sep 1, 2019 · 0 comments

Comments

@bnomei
Copy link

bnomei commented Sep 1, 2019

the json example in the readme has no self in various params but the json file from the tests does have these set.
https://github.com/paragonie/csp-builder#example
https://github.com/paragonie/csp-builder/blob/e9a7560fd3f133a85f03c51de5fc051ac97630a7/test/vectors/basic-csp.json

for example i am guessing that using the example from the readme does not set self fore base-uri. but that might not be a good example then, right? the resulting csp will not work well.

unless i am misstaken please adjust the readme json example so it will have sensible defaults where self might be needed. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant