Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default RemoteFetch constructor always throws exception #30

Open
gamringer opened this issue Oct 8, 2019 · 1 comment
Open

Default RemoteFetch constructor always throws exception #30

gamringer opened this issue Oct 8, 2019 · 1 comment

Comments

@gamringer
Copy link

gamringer commented Oct 8, 2019 •
edited

The default declaration of RemoteFetch always throws a FilesystemException because $dataDir is empty. I think $dataDir should be a mandatory argument or have a default value of ".". What do you think.

It occured when using https://github.com/paragonie/quill with the default $http constructor argument. I stumbled upon this when trying the example from the Quill Readme on PHP 7.2.18
@paragonie-scott
Copy link
Member

I think making it mandatory makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gamringer @paragonie-scott